From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja@tarantool.org>
Date: Fri, 15 Feb 2019 16:21:58 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: Re: [tarantool-patches] [PATCH v4 02/12] evio: expose
 evio_setsockopt_server function
Message-ID: <20190215132158.GE24683@chai>
References: <cover.1548883137.git.v.shpilevoy@tarantool.org>
 <95b265f0fff41d30076f92e282bbcbda96984f72.1548883137.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <95b265f0fff41d30076f92e282bbcbda96984f72.1548883137.git.v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org
Cc: vdavydov.dev@gmail.com
List-ID: <tarantool-patches.dev.tarantool.org>

* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/01/31 10:28]:
> It is going to be used in SWIM module to set UDP server socket
> options. Apparently this function sets some usefull flags like
> NONBLOCK, REUSEADDR.

A bit more detailed comment wouldn't harm for a public function:
which options this function is setting and why.

Otherwise OK to push.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov