From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6C5ED22903 for ; Fri, 15 Feb 2019 07:58:41 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uUVdpu4vyWn2 for ; Fri, 15 Feb 2019 07:58:41 -0500 (EST) Received: from smtp10.mail.ru (smtp10.mail.ru [94.100.181.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 29F8320770 for ; Fri, 15 Feb 2019 07:58:41 -0500 (EST) Received: from [185.6.245.178] (port=59046 helo=atlas.local) by smtp10.mail.ru with esmtpa (envelope-from ) id 1gud4h-0005RC-LE for tarantool-patches@freelists.org; Fri, 15 Feb 2019 15:58:39 +0300 Date: Fri, 15 Feb 2019 15:58:34 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 2/3] box: don't set cluster uuid and instance id in initial snapshot Message-ID: <20190215125834.GA24683@chai> References: <2686110152a446ba3d039cf0a644b1c6d102f813.1550232829.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2686110152a446ba3d039cf0a644b1c6d102f813.1550232829.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/02/15 15:26]: > They aren't needed there as we reset them anyway once the snapshot is > replayed on initial bootstrap. OTOH having them results in calling > replica_{set,clear}_id twice on initial bootstrap, which will look weird > when I patch them to log the ids. So let's remove them from the initial > snapshot. This makes the initial bootstrap impossible to recover from as > it is, but that shouldn't be an issue since one can always bootstrap a > new instance in a normal way. This also allows us to make cluster uuid > truly immutable (currently, one can update it with REPLACE). This patch is Ok to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov