From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 15 Feb 2019 12:42:11 +0300 From: Vladimir Davydov Subject: Re: [PATCH] replication: improve join/subscribe logging Message-ID: <20190215094211.kill6uborsmewl6w@esperanza> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: kostja@tarantool.org Cc: tarantool-patches@freelists.org List-ID: On Thu, Feb 14, 2019 at 08:44:36PM +0300, Vladimir Davydov wrote: > This patch makes logging a little bit more verbose so as to facilitate > post-mortem replication failure analysis: > > - When an instance starts up, print its uuid and vclock. > - When a replica connects to a master, print the master's uuid. > - Log join/subscribe events in the master's log; print replica uuid, > address, and vclock. Come to think of it, we also need to print id assigned to each replica, otherwise vclocks wouldn't make much sense. I'll patch replica_{set,clear}_id in v2. Also, we should probably be more verbose in applier as well and print local and remote vclocks when an applier subscribes. Will do it, too.