From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Thu, 14 Feb 2019 17:57:28 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH] vinyl: fix crash if iterator is used throughout DDL
Message-ID: <20190214145728.3fbqtpthggcekpbs@esperanza>
References: <882b7f20bb0dbc7310dd95eee28af583b88c1413.1550150143.git.vdavydov.dev@gmail.com>
 <20190214135446.GB17583@chai>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190214135446.GB17583@chai>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Thu, Feb 14, 2019 at 04:54:46PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/02/14 16:23]:
> > vy_run_iterator doesn't take a reference to the format it uses to decode
> > statements loaded from disk. As a result, the format may be deleted by
> > DDL, leading to a use-after-free bug. Fix this by taking a reference to
> > the format used by an iterator.
> 
> Please add a comment before _ref():
> 
> /* 
>  * Please remove this kludge when proper DDL locking is
>  * implemented on transaction management level or multi-version
>  * data dictionary is in place. 
>  */
> > 
> 
> With that, oK to push.

Pushed to 2.1 and 1.10.