From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 14 Feb 2019 16:57:52 +0300 From: Konstantin Osipov Subject: Re: [tarantool-patches] [PATCH v2 1/4] box: move memtx_tree implementation to source file Message-ID: <20190214135752.GC17583@chai> References: <0e4dceb9b4dd6ae72bca08823ad7b5a8a6f85ce6.1550050245.git.kshcherbatov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0e4dceb9b4dd6ae72bca08823ad7b5a8a6f85ce6.1550050245.git.kshcherbatov@tarantool.org> To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com, Kirill Shcherbatov List-ID: * Kirill Shcherbatov [19/02/13 13:03]: > Refactored memtx_tree code so that memtx_tree.h contained only > the signature of the tree object constructor memtx_tree_index_new, > while all implementation details were in memtx_tree.c. > This will further allow to template the implementation details. > > Needed for #3961 This patch is OK to push. I am not sure if any of the following patches will be in, but hiding more details in the implementation is always a good thing. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov