From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 12 Feb 2019 21:15:16 +0300 From: Konstantin Osipov Subject: Re: [PATCH v3 2/4] vinyl: remove extra quota check from vy_quota_use Message-ID: <20190212181516.GD21518@chai> References: <1762d22b6826352d5dc1a3e8bb3a2b3e6026f5d7.1549990576.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1762d22b6826352d5dc1a3e8bb3a2b3e6026f5d7.1549990576.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [19/02/12 20:28]: > Before waking up a fiber that is waiting for quota, we always first > check if it can actually consume it, see vy_quota_signal. Hence the > extra check in vy_quota_use is needed only to prevent spurious wakeups. > It doesn't seem to be wise to add such a check to a hot path as a > counter-mesaure to such an unlikely scenario. Let's remove it - after > all it isn't critical if a spuriously woken up fiber exceeds the limit. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov