From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Tue, 12 Feb 2019 12:02:24 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH] vinyl: cancel reader and writer threads on shutdown
Message-ID: <20190212090224.5mbvhbxsiqs6kgfk@esperanza>
References: <5448d74ca0079657d09b342c639013d5b00f7899.1549906085.git.vdavydov.dev@gmail.com>
 <20190211181605.GB9960@chai>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190211181605.GB9960@chai>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Mon, Feb 11, 2019 at 09:16:05PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/02/11 20:41]:
> > Currently, vinyl won't shutdown until all reader and writer threads
> > gracefully complete all their pending requests, which may take a while,
> > especially for writer threads that may happen to be doing compaction at
> > the time. This is annoying - there's absolutely no reason to delay
> > termination in such a case. Let's forcefully cancel all threads, like we
> > do in case of relay threads.
> > 
> > This should fix sporadic vinyl/replica_quota test hang.
> > 
> > Closes #3949
> 
> OK to push.

Pushed to 2.1 and 1.10.