From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 11 Feb 2019 21:16:05 +0300 From: Konstantin Osipov Subject: Re: [PATCH] vinyl: cancel reader and writer threads on shutdown Message-ID: <20190211181605.GB9960@chai> References: <5448d74ca0079657d09b342c639013d5b00f7899.1549906085.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5448d74ca0079657d09b342c639013d5b00f7899.1549906085.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [19/02/11 20:41]: > Currently, vinyl won't shutdown until all reader and writer threads > gracefully complete all their pending requests, which may take a while, > especially for writer threads that may happen to be doing compaction at > the time. This is annoying - there's absolutely no reason to delay > termination in such a case. Let's forcefully cancel all threads, like we > do in case of relay threads. > > This should fix sporadic vinyl/replica_quota test hang. > > Closes #3949 OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov