From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 11 Feb 2019 15:41:56 +0300 From: Konstantin Osipov Subject: Re: [PATCH v2] box: enable WAL before making initial checkpoint Message-ID: <20190211124156.GB20767@chai> References: <504138963321d4795b577d73f86e013fde9090b8.1549644534.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [19/02/11 15:34]: > While a replica is bootstrapped from a remote master, vinyl engine > may need to perform compaction, which means that it may write to > the _vinyl_deferred_delete system space. Compaction proceeds fully > asynchronously, i.e. a write may occur after the join stage is > complete, but before the WAL is initialized, in which case the new > replica will crash. To make sure a race like that won't happen, let's > setup WAL before making the initial checkpoint. The WAL writer is now > initialized right before starting the WAL thread and so we don't need > to split WAL struct into the thread and the writer anymore. > > Closes #3968 OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov