From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 8 Feb 2019 20:26:26 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] Re: [PATCH v2 3/8] vinyl: rename lsm->range_heap to max_compaction_priority Message-ID: <20190208172626.in2jg3rjlevkl77m@esperanza> References: <871bdf9973351a6fe57225b08eedc5cff04e3727.1548349067.git.vdavydov.dev@gmail.com> <20190208171946.GH4588@chai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190208171946.GH4588@chai> To: Konstantin Osipov Cc: tarantool-patches@freelists.org List-ID: On Fri, Feb 08, 2019 at 08:19:46PM +0300, Konstantin Osipov wrote: > * Vladimir Davydov [19/01/24 20:16]: > > The name 'range_heap' is ambiguous, because it's unclear what range > > should be on top of the heap. We need to introduce another heap of > > ranges ordered differently, so let's rename to max_compaction_priority > > to avoid confusion. > > I think the old name was better. And I think we could avoid > introducing another heap ;) Yep, I removed the heap in the new version and left the old name. See the branch pls.