From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 8502227593 for ; Fri, 8 Feb 2019 12:19:48 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r0orNpZI4z7b for ; Fri, 8 Feb 2019 12:19:48 -0500 (EST) Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3F6AC2749D for ; Fri, 8 Feb 2019 12:19:48 -0500 (EST) Received: from [185.6.245.178] (port=49214 helo=atlas.local) by smtp58.i.mail.ru with esmtpa (envelope-from ) id 1gs9oY-0005H1-FA for tarantool-patches@freelists.org; Fri, 08 Feb 2019 20:19:46 +0300 Date: Fri, 8 Feb 2019 20:19:46 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 3/8] vinyl: rename lsm->range_heap to max_compaction_priority Message-ID: <20190208171946.GH4588@chai> References: <871bdf9973351a6fe57225b08eedc5cff04e3727.1548349067.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871bdf9973351a6fe57225b08eedc5cff04e3727.1548349067.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/01/24 20:16]: > The name 'range_heap' is ambiguous, because it's unclear what range > should be on top of the heap. We need to introduce another heap of > ranges ordered differently, so let's rename to max_compaction_priority > to avoid confusion. I think the old name was better. And I think we could avoid introducing another heap ;) -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov