From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 2479C273C1 for ; Fri, 8 Feb 2019 08:37:17 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1QxaZPBtIl4t for ; Fri, 8 Feb 2019 08:37:17 -0500 (EST) Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id D58BA273B8 for ; Fri, 8 Feb 2019 08:37:16 -0500 (EST) Date: Fri, 8 Feb 2019 16:37:14 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH 0/8] Eliminate affinity from source code Message-ID: <20190208133714.hpdygylpr7phfaoq@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Nikita Pettik Hello, On 28 Dec 11:34, Nikita Pettik wrote: > Branch: https://github.com/tarantool/tarantool/tree/np/gh-3698-eliminate-affinity > Issue: > https://github.com/tarantool/tarantool/issues/3698 > https://github.com/tarantool/tarantool/issues/3886 > > Main purpose of current patch-set is to remove affinity from source > code. We are starting from introducing itermediate converstors > from affinity to field type and vice versa. Then, step-by-step we > are replacing affinity usages with field type. Non-trivial part of > this patch-set is removing numeric affinity (see third patch in > series and commit message). > > It worth noting that current patch-set also fixes issue connected > with invisible to query optimizer indexes, which are created from > Lua: to choose suitable index QO checked affinity compatibility of > key part and field def. As a result, indexes created without affinity > field couldn't be used to process query. > > Nikita Pettik (8): > sql: remove SQLITE_ENABLE_UPDATE_DELETE_LIMIT define > sql: use field type instead of affinity for type_def > sql: remove numeric affinity > sql: replace affinity with field type for func > sql: replace field type with affinity for VDBE runtime > sql: replace affinity with field type in struct Expr > sql: clean-up affinity from SQL source code > Remove affinity from field definition I've checked your patch set into 2.1 branch. -- Regards, Kirill Yukhin