From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 6 Feb 2019 16:50:32 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] [PATCH 0/3] Promote vclock only for successful writes Message-ID: <20190206135032.q2vg54o7hj56kpgo@esperanza> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Georgy Kirichenko Cc: tarantool-patches@freelists.org List-ID: This is v2 so you should've added v2 to the subject and a brief change log to the body. On Wed, Feb 06, 2019 at 11:29:56AM +0300, Georgy Kirichenko wrote: > Promote tx and wal vclock only if corresponding row was successfully > written to wal. This prevents tarantool from lsn gaps in case of an wal > error as well as from skipped rows in case of replication errors. > > Branch: https://github.com/tarantool/tarantool/tree/g.kirichenko/gh-2283-dont-skip-rows-after-errors > Issue: https://github.com/tarantool/tarantool/issues/2283 > > Georgy Kirichenko (3): > Do not promote wal vclock for failed writes > Enforce applier out of order protection > Promote replicaset.vclock only after wal > > src/box/applier.cc | 46 +-- > src/box/wal.c | 57 ++- > test/box/errinj.result | 23 ++ > test/box/errinj.test.lua | 8 + > test/replication/skip_conflict_row.test.lua | 19 + > test/xlog-py/dup_key.result | 12 +- > test/xlog-py/dup_key.test.py | 23 +- > test/xlog/errinj.result | 1 - > test/xlog/panic_on_lsn_gap.result | 377 -------------------- > test/xlog/panic_on_lsn_gap.test.lua | 136 ------- > 10 files changed, 116 insertions(+), 586 deletions(-) > delete mode 100644 test/xlog/panic_on_lsn_gap.result > delete mode 100644 test/xlog/panic_on_lsn_gap.test.lua