From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 86F43251F7 for ; Tue, 5 Feb 2019 11:49:07 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HOkWIta_rAx8 for ; Tue, 5 Feb 2019 11:49:07 -0500 (EST) Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 38B8F2507E for ; Tue, 5 Feb 2019 11:49:07 -0500 (EST) Received: by smtp14.mail.ru with esmtpa (envelope-from ) id 1gr3uD-00060F-B4 for tarantool-patches@freelists.org; Tue, 05 Feb 2019 19:49:05 +0300 Date: Tue, 5 Feb 2019 19:49:05 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 3/9] vinyl: use uncompressed run size for range split/coalesce/compaction Message-ID: <20190205164905.GC6811@chai> References: <20190121094213.yzfawcs7mgkqxi3e@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190121094213.yzfawcs7mgkqxi3e@esperanza> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/01/21 13:15]: > On Mon, Jan 21, 2019 at 12:17:02AM +0300, Vladimir Davydov wrote: > > Historically, when considering splitting or coalescing a range or > > updating compaction priority, we use sizes of compressed runs (see > > bytes_compressed). This makes the algorithms dependent on whether > > compression is used or not and how effective it is, which is weird, > > because compression is a way of storing data on disk - it shouldn't > > affect the way data is partitioned. E.g. if we turned off compression > > at the first LSM tree level, which would make sense, because it's > > relatively small, we would affect the compaction algorithm because > > of this. > > > > That said, let's use uncompressed run sizes when considering range > > tree transformations. > > This results in occasional failures of vinyl/deferred_delete.test.lua. > I amended the patch on the branch to fix this. Here's the diff: > I don't understand why you had to replace random data with string.rep('z', ...). Otherwise lgtm. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov