From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 9CFDB23A6D for ; Tue, 29 Jan 2019 08:33:18 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UZFLnA-GDE_4 for ; Tue, 29 Jan 2019 08:33:18 -0500 (EST) Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 07F1B23584 for ; Tue, 29 Jan 2019 08:33:17 -0500 (EST) Received: by smtp56.i.mail.ru with esmtpa (envelope-from ) id 1goTVr-0001wA-5O for tarantool-patches@freelists.org; Tue, 29 Jan 2019 16:33:15 +0300 Date: Tue, 29 Jan 2019 16:33:14 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] tuple: fix hashing of integer numbers Message-ID: <20190129133314.6d3rvqfxgo7ozgak@tarantool.org> References: <3bb1fa694ee45642ab6b3c09926f3c577a109fab.1548171646.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3bb1fa694ee45642ab6b3c09926f3c577a109fab.1548171646.git.vdavydov.dev@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Hello Vladimir, On 22 Jan 19:13, Vladimir Davydov wrote: > Integer numbers stored in tuples as MP_FLOAT/MP_DOUBLE are hashed > differently from integer numbers stored as MP_INT/MP_UINT. This breaks > select() for memtx hash indexes and vinyl indexes (the latter use bloom > filters). Fix this by converting MP_FLOAT/MP_DOUBLE to MP_INT/MP_UINT > before hashing if the value can be stored as an integer. This is > consistent with the behavior of tuple comparators, which treat MP_FLOAT > and MP_INT as equal in case they represent the same number. > > Closes #3907 > --- > https://github.com/tarantool/tarantool/issues/3907 > https://github.com/tarantool/tarantool/commits/dv/gh-3907-fix-integer-number-hashing I've checked your patch into 2.1 branch. -- Regards, Kirill Yukhin