From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 24 Jan 2019 20:26:31 +0300 From: Vladimir Davydov Subject: Re: [PATCH v2 2/4] Set is_temporary flag for formats of ephemeral spaces Message-ID: <20190124172631.ja77fzab2m2rerco@esperanza> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Kirill Yukhin Cc: tarantool-patches@freelists.org List-ID: On Thu, Jan 24, 2019 at 03:48:46PM +0300, Kirill Yukhin wrote: > Before the patch, when ephemeral space was created flag > is_temporary was set after space was actually created. > Which in turn lead to corresponding flag of tuple_format > being set to `false`. > So, having heavy load using ephemeral spaces (almost any > SQL query) and snapshotting at the same time might lead > to OOM, since tuples of ephemeral spaces were not marked > as temporary and were not gc-ed. > Patch sets the flag in space definition. > --- > src/box/space.c | 2 +- > src/box/space_def.c | 14 ++++++++++++++ > src/box/space_def.h | 9 +++++++++ > src/box/sql.c | 6 +----- > 4 files changed, 25 insertions(+), 6 deletions(-) Pushed to 2.1