From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 9F64D257A5 for ; Thu, 24 Jan 2019 08:56:24 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W1irb-Q-oxGC for ; Thu, 24 Jan 2019 08:56:24 -0500 (EST) Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id DE01E25289 for ; Thu, 24 Jan 2019 08:56:23 -0500 (EST) Date: Thu, 24 Jan 2019 16:56:21 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] sql: make IN operator stop ignoring type and collation Message-ID: <20190124135620.ubtuykuusq25ezmz@tarantool.org> References: <20190116133401.5844-1-korablev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190116133401.5844-1-korablev@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Nikita Pettik Hello, On 16 Jan 16:34, Nikita Pettik wrote: > SQLite discards type and collation of IN operator when it comes with > only one operand. This leads to different results of straight comparison > using '=' operator and IN: > > SELECT x FROM t1 WHERE x IN (1.0); > -- Result is empty set > SELECT x FROM t1 WHERE x = 1.0; > - - ['1'] > > Lets remove this strange ignorance and always take into consideration > types and collations of operands. > > Closes #3934 > --- > Branch: https://github.com/tarantool/tarantool/tree/np/gh-3934-IN-operator-fix > Issue: https://github.com/tarantool/tarantool/issues/3934 I've checked your patch into 2.1 branch. -- Regards, Kirill Yukhin