From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id B406C25965 for ; Thu, 24 Jan 2019 07:31:02 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id My2r1dfOYCrQ for ; Thu, 24 Jan 2019 07:31:02 -0500 (EST) Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 09856257C8 for ; Thu, 24 Jan 2019 07:31:01 -0500 (EST) Date: Thu, 24 Jan 2019 15:30:59 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v2 1/5] sql: introduce structs assembling DDL arguments during parsing Message-ID: <20190124123059.GB13097@chai> References: <0fcc585532a1f1200a7dfd4a8e911ecf9f2c94aa.1548265148.git.korablev@tarantool.org> <20190124083630.GC3573@chai> <4029AB62-F67D-45F0-9370-2F3A37CB9D09@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4029AB62-F67D-45F0-9370-2F3A37CB9D09@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: "n.pettik" Cc: tarantool-patches@freelists.org, Vladislav Shpilevoy * n.pettik [19/01/24 13:51]: > >> + * One of parse_def structures which are used to > >> + * assemble and carry arguments of DDL routines > >> + * from parse.y > >> + */ > >> + void *alter_entity_def; > > > > Please consider adding a type code to the base entity def, so that > > you can use a base struct reference rather than void *. > > Please, look at code and explain why do we need type > code? At first I added it, but it turned out that such code > was completely useless. The only real usage was to > assert that type of structure matches with its code. To assert the structure matches with its code. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov