From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6F493266F0 for ; Fri, 18 Jan 2019 13:00:55 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aaBJJ2xIfCdT for ; Fri, 18 Jan 2019 13:00:55 -0500 (EST) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id CF09E266EA for ; Fri, 18 Jan 2019 13:00:54 -0500 (EST) Date: Fri, 18 Jan 2019 21:00:52 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v1 1/4] box: rename space->opts checks to checks_ast Message-ID: <20190118180052.GA24439@chai> References: <347e0f9e4c81bf76520c167a00f7af661b76aa64.1547128310.git.kshcherbatov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <347e0f9e4c81bf76520c167a00f7af661b76aa64.1547128310.git.kshcherbatov@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: korablev@tarantool.org, Kirill Shcherbatov * Kirill Shcherbatov [19/01/10 23:12]: > The checks field of space_opts object renamed to checks_ast to avoid a > confusion due to introduction of a new object sql_check, representing > precompiled VDBE program to execute. Please use name check_constraint_expr A common abbreviation for foreign key constraint is fk, check constarint - ck, not null - nn, so an alternative family of names would be fk_constraint, ck_constraint, nn_constraint. Feel free to use it if you like a bit shorter form. > + if (def->opts.checks_ast != NULL && > + sql_checks_resolve_space_def_reference(def->opts.checks_ast, Please name the module 'check_constraint' or ck_constraint, and rename all the functions accordingly. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov