From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 313BB258C4 for ; Thu, 17 Jan 2019 08:51:46 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0WGfMM2qAFDP for ; Thu, 17 Jan 2019 08:51:46 -0500 (EST) Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id DEDA92346A for ; Thu, 17 Jan 2019 08:51:45 -0500 (EST) Received: by smtp58.i.mail.ru with esmtpa (envelope-from ) id 1gk859-0000m7-A6 for tarantool-patches@freelists.org; Thu, 17 Jan 2019 16:51:43 +0300 Date: Thu, 17 Jan 2019 16:51:42 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 04/12] vinyl: rename compact to compaction Message-ID: <20190117135142.GQ28204@chai> References: <20190117113449.GH28204@chai> <20190117120818.fm3hfm7hvajn7e5c@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190117120818.fm3hfm7hvajn7e5c@esperanza> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/01/17 16:08]: > On Thu, Jan 17, 2019 at 02:34:49PM +0300, Konstantin Osipov wrote: > > * Vladimir Davydov [19/01/15 17:20]: > > > compact_input sounds confusing, because 'compact' works as an adjective > > > here. Saving 3 characters per variable/stat name related to compaction > > > doesn't justify this. Let's rename 'compact' to 'compaction' both in > > > stats and in the code. > > > > Actually, compaction_input also can be confused with the current > > compaction queue size. Perhaps we could play with word "total" to > > distinguish the current/last amounts and the total amounts in variable > > names. > > The names are long enough as they are so I'd avoid adding total_ > prefixes. For queue, we have compaction_queue. How do you define "long enough" ? Perhaps they look long inthe source code but they are definitely not long when displayed on a computer screen in box.stat.vinyl() output. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov