From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Thu, 17 Jan 2019 15:08:19 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] Re: [PATCH 04/12] vinyl: rename compact to
 compaction
Message-ID: <20190117120818.fm3hfm7hvajn7e5c@esperanza>
References: <cover.1547558871.git.vdavydov.dev@gmail.com>
 <a3efe3513cd0bdfb4176cd746689fcecbc98eca8.1547558871.git.vdavydov.dev@gmail.com>
 <20190117113449.GH28204@chai>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190117113449.GH28204@chai>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Thu, Jan 17, 2019 at 02:34:49PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/01/15 17:20]:
> > compact_input sounds confusing, because 'compact' works as an adjective
> > here. Saving 3 characters per variable/stat name related to compaction
> > doesn't justify this. Let's rename 'compact' to 'compaction' both in
> > stats and in the code.
> 
> Actually, compaction_input also can be confused with the current
> compaction queue size. Perhaps we could play with word "total" to
> distinguish the current/last amounts and the total amounts in variable
> names.

The names are long enough as they are so I'd avoid adding total_
prefixes. For queue, we have compaction_queue.