From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Date: Thu, 17 Jan 2019 14:58:43 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [tarantool-patches] [PATCH v1 1/1] implement mp_stack class
Message-ID: <20190117115843.nqellm5mmsglqnlf@tkn_work_nb>
References: <9613f79e65d9838763422aae0bfb3ca9e2901a32.1547645639.git.kshcherbatov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <9613f79e65d9838763422aae0bfb3ca9e2901a32.1547645639.git.kshcherbatov@gmail.com>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: vdavydov.dev@gmail.com, kostja@tarantool.org, tarantool-patches@freelists.org, Kirill Shcherbatov <kshcherbatov@gmail.com>
List-ID: <tarantool-patches.dev.tarantool.org>

Look at the `make doc` warnings, the doxygen format is slightly
different then yours one.

Please, start the commit mesaage from the upper letter (because it has
no prefix).

Can you please share how do you intend to use it? One or more real
cases.

WBR, Alexander Turenko.

On Wed, Jan 16, 2019 at 04:36:12PM +0300, Kirill Shcherbatov wrote:
> From: Kirill Shcherbatov <kshcherbatov@gmail.com>
> 
> https://github.com/tarantool/tarantool/tree/kshch/gh-1012-msgpuck-class

It is tarantool/small, not tarantool/tarantool.

> +/**
> + * \brief Advance a mp_stack::curr attribute of the mp_stack.
> + * \stack top frame. The \stack must not be empty.
> + * \retval true, when the top frame have already parsed:
> + *         mp_stack::curr >= mp_stack::size; false otherwise.

mp_stack::curr -> mp_stack_top()::curr
mp_stack::size -> mp_stack_top()::size