From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4A8C7262AD for ; Thu, 17 Jan 2019 06:34:51 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ljKGXAiHSBQK for ; Thu, 17 Jan 2019 06:34:51 -0500 (EST) Received: from smtp20.mail.ru (smtp20.mail.ru [94.100.179.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 075BA2049C for ; Thu, 17 Jan 2019 06:34:50 -0500 (EST) Received: from [185.6.245.178] (port=53412 helo=atlas.local) by smtp20.mail.ru with esmtpa (envelope-from ) id 1gk5wf-0004fc-HV for tarantool-patches@freelists.org; Thu, 17 Jan 2019 14:34:49 +0300 Date: Thu, 17 Jan 2019 14:34:49 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 04/12] vinyl: rename compact to compaction Message-ID: <20190117113449.GH28204@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org * Vladimir Davydov [19/01/15 17:20]: > compact_input sounds confusing, because 'compact' works as an adjective > here. Saving 3 characters per variable/stat name related to compaction > doesn't justify this. Let's rename 'compact' to 'compaction' both in > stats and in the code. Actually, compaction_input also can be confused with the current compaction queue size. Perhaps we could play with word "total" to distinguish the current/last amounts and the total amounts in variable names. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov