From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 542B02621E for ; Thu, 17 Jan 2019 05:56:17 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6RIuETu_zGlH for ; Thu, 17 Jan 2019 05:56:17 -0500 (EST) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 69A76261C6 for ; Thu, 17 Jan 2019 05:56:16 -0500 (EST) Date: Thu, 17 Jan 2019 13:56:13 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH 1/6] sql: move constraint name to struct contraint_parse Message-ID: <20190117105613.GC28204@chai> References: <499ebc6e21ade22cde794f8470bf5900131d42f5.1547035183.git.korablev@tarantool.org> <834ae33b-dddd-3f51-f6f1-ef5bcc24e240@tarantool.org> <3C226FE6-A27A-46CD-8C83-AA839AAF08F2@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3C226FE6-A27A-46CD-8C83-AA839AAF08F2@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Vladislav Shpilevoy * n.pettik [19/01/16 23:09]: > struct constraint_parse { > /** Name of table which constraint belongs to. */ > - struct SrcList *table_name; > + struct SrcList *table; > /** Name of the constraint currently being parsed. */ > struct Token name; > + /** > + * List of columns involved in constraint definition: > + * indexed or referencing columns. > + */ > + struct ExprList *cols; Why not use constraint_def here and all future parser-specific objects? _def is our widely used abbreviation for "definition". A parser creates a constraint definition, and then it is used to create a runtime constraint object - struct constraint. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov