From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 79E68252D7 for ; Fri, 11 Jan 2019 09:12:49 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vbTKV4V8-YkS for ; Fri, 11 Jan 2019 09:12:49 -0500 (EST) Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3B5662506C for ; Fri, 11 Jan 2019 09:12:49 -0500 (EST) Date: Fri, 11 Jan 2019 17:12:47 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v1 4/4] sql: make sql checks on server side Message-ID: <20190111141247.GD31711@chai> References: <2d7c73e83bcee024ffcc095854a31bcd46f6ccab.1547128310.git.kshcherbatov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2d7c73e83bcee024ffcc095854a31bcd46f6ccab.1547128310.git.kshcherbatov@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: korablev@tarantool.org, Kirill Shcherbatov * Kirill Shcherbatov [19/01/10 23:12]: > + if (sql_checks_run(space->sql_checks, > + space->def->opts.checks_ast, space->def, > + old_tuple_raw, new_tuple_raw) != 0) { > + diag_raise(); Do you have a module named sql_checks? I believe you don't, one reason is that we don't use plural for module names. Then your method name should be sql_run_checks. But since this name is meaningless, why not use a straightforward and self-explanatory name, for example sql_validate_check_constraints()? -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov