From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 0AFD223FE7 for ; Wed, 9 Jan 2019 09:01:11 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HHOPzZsNp0mV for ; Wed, 9 Jan 2019 09:01:10 -0500 (EST) Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id BF36323F46 for ; Wed, 9 Jan 2019 09:01:10 -0500 (EST) Date: Wed, 9 Jan 2019 17:01:08 +0300 From: Konstantin Osipov Subject: [tarantool-patches] Re: [PATCH v4 2/2] box: implement on_shutdown triggers Message-ID: <20190109140108.GH20509@chai> References: <9dcaebf07a3018f46968748a8df04007b36ba4d6.1546090754.git.sergepetrenko@tarantool.org> <20190109101449.2325eebtrj7xsdlr@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190109101449.2325eebtrj7xsdlr@esperanza> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Serge Petrenko * Vladimir Davydov [19/01/09 13:16]: > > +/** Invoked on box shutdown. */ > > +extern struct rlist box_on_shutdown; > > + > > Nit: it would be nice to say here that it is only invoked upon receiving > a terminating signal, not when os.exit() is called. This is a usability problem. We need to monkey-patch os.exit() to call these triggers. Sergey, please do it in a separate patch. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov