From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 7D71D241C5
	for <tarantool-patches@freelists.org>; Wed,  9 Jan 2019 03:57:31 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 5_huSKnLm8eR for <tarantool-patches@freelists.org>;
	Wed,  9 Jan 2019 03:57:31 -0500 (EST)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3C9B023FDA
	for <tarantool-patches@freelists.org>; Wed,  9 Jan 2019 03:57:31 -0500 (EST)
Date: Wed, 9 Jan 2019 11:57:33 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: fix lemon memory leak reported
 by ASAN
Message-ID: <20190109085733.2gq2c6ru6wrxahav@tkn_work_nb>
References: <9dbcaa3afae39cc46a8e6da5e00b5d62179ed016.1546692811.git.alexander.turenko@tarantool.org>
 <20190109072015.gruplrs6gyrcu66w@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20190109072015.gruplrs6gyrcu66w@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@freelists.org, Nikita Pettik <korablev@tarantool.org>

On Wed, Jan 09, 2019 at 10:20:15AM +0300, Kirill Yukhin wrote:
> Hello,
> On 05 Jan 16:13, Alexander Turenko wrote:
> > It catched by ASAN at build time (lemon is executed to generate
> > parse.[ch]), so tarantool couldn't be built with -DENABLE_ASAN=ON.
> > ---
> > 
> > no issue
> > https://github.com/tarantool/tarantool/tree/Totktonada/fix-lemon-memleak
> I've pushed your patch into 2.1 branch.
> 
> Should we propose a patch to SQLite?

It is not so important unless you are using ASAN and I think in SQLite
it only run in the maintainer mode.

SQLite requires to sign-off dedication document before contribute. The
patch I think is not enough reason to do that.

WBR, Alexander Turenko.