From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 29 Dec 2018 16:22:14 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] Re: [PATCH v1 4/4] box: refactor tuple_init_field_map to use bitmap Message-ID: <20181229132213.w7qpudy45tpye7p5@esperanza> References: <20181227191249.vojcr2jl3ugnm5pw@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org List-ID: On Sat, Dec 29, 2018 at 03:58:34PM +0300, Kirill Shcherbatov wrote: > > field_count can't be 0 - otherwise we would bail out early. > It is not so, try paste assert here and run > > s = box.schema.space.create('test', {engine = engine}) > pk = s:create_index('pk') > sk = s:create_index('sk', {parts = {{2, 'unsigned', is_nullable = true}}}) > s:replace{} -- Fail OK, I confused tuple field count with format field count.