From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 28 Dec 2018 11:00:26 +0300 From: Vladimir Davydov Subject: Re: [PATCH 1/3] Add luaT_iscallable with support of cdata metatype Message-ID: <20181228080026.xil3m3luy2eiuebz@esperanza> References: <20181226183556.gilqpkhj4gmliby4@esperanza> <20181228014649.7v4zm24neusuqelu@tkn_work_nb> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181228014649.7v4zm24neusuqelu@tkn_work_nb> To: Alexander Turenko Cc: tarantool-patches@freelists.org List-ID: On Fri, Dec 28, 2018 at 04:46:50AM +0300, Alexander Turenko wrote: > Updated Totktonada/gh-3276-on-board-merger and > Totktonada/gh-3276-on-board-merger-1.10. > > On Wed, Dec 26, 2018 at 09:35:56PM +0300, Vladimir Davydov wrote: > > On Sun, Dec 16, 2018 at 11:17:24PM +0300, Alexander Turenko wrote: > > > Needed for #3276. > > > --- > > > extra/exports | 1 + > > > src/lua/utils.c | 43 ++++++++++++++++ > > > src/lua/utils.h | 10 ++++ > > > test/app-tap/module_api.c | 10 ++++ > > > test/app-tap/module_api.test.lua | 85 +++++++++++++++++++++++++++++++- > > > 5 files changed, 147 insertions(+), 2 deletions(-) > > > > > > diff --git a/extra/exports b/extra/exports > > > index 5f69e0730..52f0b2378 100644 > > > --- a/extra/exports > > > +++ b/extra/exports > > > @@ -134,6 +134,7 @@ luaT_call > > > luaT_cpcall > > > luaT_state > > > luaT_tolstring > > > +luaT_iscallable > > > > Do we really need to export it? > > No, we don't obligated to export it. I'll remove it and rewrite the test > case (at least I'll try) if you sure we shouldn't. But I think it is Ah, you need it for a unit test. OK, let's leave it then. > better to leave it as the public function. > > I think luajit's support of cdata (in C/Lua APIs) could be better and we > can invest some effort to make it better for users of our C API and ffi. > Also filed #3915.