From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 27 Dec 2018 22:13:32 +0300 From: Vladimir Davydov Subject: Re: [PATCH v1 0/4] box: JSON preparatory patchset Message-ID: <20181227191332.ruxcmeoh67olgcqt@esperanza> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org, kostja@tarantool.org List-ID: v1? I thought it at least v2 On Thu, Dec 27, 2018 at 02:15:51PM +0300, Kirill Shcherbatov wrote: > Preparatory patch set for JSON indexes: > - Implemented a new json_token_path_snprint routine able to print > JSON path to field by field specified working like cannonical > snprintf routine > - New json_token_is_leaf helper to test node is JSON tree leaf > - Implemented a new bitmap_majority_test routine to check if the > passed bitmap a "majorates" bitmap b (test that a contains at > least all b bits). > - Reworked tuple_init_field_map with required fields bitmap - > a scallable approach able to work with JSON multilevel fields > tree. > > http://github.com/tarantool/tarantool/tree/kshch/gh-3908-fix-ast-alter-memleak Bad link. > https://github.com/tarantool/tarantool/issues/3908 > > Kirill Shcherbatov (4): > lib: introduce json_tree_snprint_path > lib: introduce json_token_is_leaf helper > box: introduce bitmap_majority_test routine > box: refactor tuple_init_field_map to use bitmap > > src/box/errcode.h | 2 +- > src/box/tuple_format.c | 103 ++++++++++++++++++++++++++-- > src/box/tuple_format.h | 18 +++++ > src/lib/bit/bit.h | 45 ++++++++++++ > src/lib/json/json.c | 68 ++++++++++++++++++ > src/lib/json/json.h | 21 ++++++ > test/box/alter_limits.result | 6 +- > test/box/ddl.result | 18 ++--- > test/box/misc.result | 2 +- > test/box/sql.result | 9 +-- > test/box/tree_pk_multipart.result | 6 +- > test/engine/ddl.result | 21 ++---- > test/engine/null.result | 39 ++++------- > test/unit/bit.c | 52 ++++++++++++++ > test/unit/bit.result | 2 + > test/unit/json.c | 110 +++++++++++++++++++++++++++++- > test/unit/json.result | 32 ++++++++- > test/vinyl/constraint.result | 9 +-- > test/vinyl/errinj.result | 9 +-- > test/vinyl/savepoint.result | 6 +- > 20 files changed, 485 insertions(+), 93 deletions(-)