From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id AC1CD20A4F for ; Thu, 27 Dec 2018 07:28:25 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id izBd-UA02kMO for ; Thu, 27 Dec 2018 07:28:25 -0500 (EST) Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0C25620703 for ; Thu, 27 Dec 2018 07:28:24 -0500 (EST) Date: Thu, 27 Dec 2018 15:28:22 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] sql: fix bug with BLOB TRIM() when X'00' in char set Message-ID: <20181227122822.j6dqx7jweoj2x5p3@tarantool.org> References: <20181215105741.28464-1-roman.habibov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181215105741.28464-1-roman.habibov@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org Hello, On 15 Dec 13:57, Roman Khabibov wrote: > The reason for the bug was that X'00' is a terminal symbol. If the char set > contained X'00', all other characters after its (inculding itself) are then > ignored. > > Closes #3543 > > Branch: https://github.com/tarantool/tarantool/tree/romankhabibov/gh-3543-trim-terminal > Issue: https://github.com/tarantool/tarantool/issues/3543 I've checked your patch into 2.1 branch. -- Regards, Kirill Yukhin