From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 27 Dec 2018 14:57:54 +0300 From: Konstantin Osipov Subject: Re: [tarantool-patches] Re: [PATCH v6 5/8] box: introduce has_json_paths flag in templates Message-ID: <20181227115754.GF18166@chai> References: <20181227115148.GC18166@chai> <20181227115220.GD18166@chai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181227115220.GD18166@chai> To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com, Kirill Shcherbatov List-ID: * Konstantin Osipov [18/12/27 14:54]: > * Konstantin Osipov [18/12/27 14:51]: > > * Kirill Shcherbatov [18/12/17 14:27]: > > > Introduced has_json_path flag for compare, hash and extract > > > functions(that are really hot) to make possible do not look to > > > path field for flat indexes without any JSON paths. > > > > Shouldn't it be a template parameter, rather than a runtime one? > > Sorry, obvious question, noticed it is already. Which begs another question, shouldn't tuple_init_field_map be a template function as well? I think time has come with json paths, it's a very hot path. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov