From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 27 Dec 2018 13:26:26 +0300 From: Vladimir Davydov Subject: Re: [PATCH] test: fix flaky fails of box/iproto_stress Message-ID: <20181227102626.2n65kqjbpefjlvyi@esperanza> References: <0be72ca859fef091bc4b967d9183287a3f90a2ec.1545780942.git.alexander.turenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0be72ca859fef091bc4b967d9183287a3f90a2ec.1545780942.git.alexander.turenko@tarantool.org> To: Alexander Turenko Cc: tarantool-patches@freelists.org List-ID: On Wed, Dec 26, 2018 at 02:37:51AM +0300, Alexander Turenko wrote: > Fixes #3911. > --- > > https://github.com/tarantool/tarantool/issues/3911 > https://github.com/tarantool/tarantool/tree/Totktonada/gh-3911-fix-box-iproto-stress > > test/box/iproto_stress.result | 1 + > test/box/iproto_stress.test.lua | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/test/box/iproto_stress.result b/test/box/iproto_stress.result > index 4239b49b8..4b7b41bd7 100644 > --- a/test/box/iproto_stress.result > +++ b/test/box/iproto_stress.result > @@ -40,6 +40,7 @@ function worker(i) > n_errors = n_errors + 1 > break > end > + conn:wait_state('active', 10) According to https://tarantool.io/en/doc/1.10/reference/reference_lua/net_box/#lua-function.net_box.new net_box.connect() waits until connection is active unless it is passed wait_connected = false. A quick glance at the code confirms that: https://github.com/tarantool/tarantool/blob/911139e379666ddff6e448184d066384a085df1e/src/box/lua/net_box.lua#L958 The question is why it doesn't happen in the test. A bug in the documentation or in net.box?