From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 255FA20B6D for ; Tue, 25 Dec 2018 08:45:57 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h1yB32sCr4oB for ; Tue, 25 Dec 2018 08:45:57 -0500 (EST) Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id CD18E208CA for ; Tue, 25 Dec 2018 08:45:56 -0500 (EST) Date: Tue, 25 Dec 2018 16:45:54 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH 0/6] Remove string of SQL statement from opts Message-ID: <20181225134554.cdiyb56mum7zly5e@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Nikita Pettik Hello, On 10 Dec 00:30, Nikita Pettik wrote: > Branch: https://github.com/tarantool/tarantool/tree/np/gh-2647-remove-sql-from-opts > Issue: https://github.com/tarantool/tarantool/issues/2647 > > After DD integration was finished, there is no need to add string > of SQL statement to space or index opts (except for VIEWs). So, > current patch-set completely removes SQL from index opts, and > removes SQL from space opts for ordinary spaces. > > Nikita Pettik (6): > sql: avoid calling sql_encode_table_opts() during trigger creation > sql: don't update SQL string during renaming > test: fix sqltester methods to drop all tables/views > sql: don't add string of 'CREATE TABLE...' to space opts > sql: don't add string of 'CREATE INDEX ...' to index opts > Remove SQL string from index opts I've checked your patch set into 2.1 branch. -- Regards, Kirill Yukhin