From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 2991E2188C for ; Tue, 25 Dec 2018 08:33:04 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tiTrW8qEP-vK for ; Tue, 25 Dec 2018 08:33:04 -0500 (EST) Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id DBA902185C for ; Tue, 25 Dec 2018 08:33:03 -0500 (EST) Date: Tue, 25 Dec 2018 16:33:01 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] sql: disallow to rename space if it is referenced by view Message-ID: <20181225133301.pgj7wwohrz6sylua@tarantool.org> References: <20181209155735.32694-1-korablev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181209155735.32694-1-korablev@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Nikita Pettik Hello, On 09 Dec 18:57, Nikita Pettik wrote: > Before this patch it was allowed to rename space which is referenced by > a view. In turn, view contains SELECT statement in a raw form (i.e. as a > string) and it is not modified during renaming routine. Hence, after > renaming space still has referencing counter > 0, but no usage of view > is allowed (since execution of SELECT results in "Space does not > exist"). To avoid such situations, lets ban renaming space if its view > reference counter > 0. > > Note that RENAME is ANSI extension, so different DBs behave in this case > in different ways - some of them allow to rename tables referenced by a > view (PostgreSQL), others - don't (Oracle). > > Closes #3746 > --- > Branch: https://github.com/tarantool/tarantool/tree/np/gh-3746-view-rename > Issue: https://github.com/tarantool/tarantool/issues/3746 I've checked your patch into 2.1 branch. -- Regards, Kirill Yukhin