From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4D665217B4 for ; Tue, 25 Dec 2018 08:30:02 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QJHF3FzwKUYB for ; Tue, 25 Dec 2018 08:30:02 -0500 (EST) Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 099752179F for ; Tue, 25 Dec 2018 08:30:01 -0500 (EST) Date: Tue, 25 Dec 2018 16:29:59 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: Fix DEFAULTs AST memory leak on alter Message-ID: <20181225132959.6rkvvnac6lkl5rgh@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Kirill Shcherbatov Hello, On 25 Dec 15:00, Kirill Shcherbatov wrote: > The space_def_destroy_fields routine is used in make_scoped_guard > on alter:space_def_new_from_tuple always pass extern_alloc=true > for sql_expr_delete routine. It shouldn't as the first-time > allocated AST (field_def_decode) is not external-allocated. > Introduced a new flag 'extern_alloc' for space_def_destroy_fields > routine. > > Closes #3908 > > http://github.com/tarantool/tarantool/tree/kshch/gh-3908-fix-ast-alter-memleak > https://github.com/tarantool/tarantool/issues/3908 I've committed your patch into 2.1 branch. -- Regards, Kirill Yukhin