From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Thu, 20 Dec 2018 16:19:45 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] [PATCH] Fix build with ENABLE_ASAN=ON
Message-ID: <20181220131945.ccp5uxqoba7qhpm6@esperanza>
References: <a6915ff7b94ead12026615b27e6a43022fffc3ab.1545309997.git.alexander.turenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a6915ff7b94ead12026615b27e6a43022fffc3ab.1545309997.git.alexander.turenko@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: Kirill Yukhin <kyukhin@tarantool.org>, tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Thu, Dec 20, 2018 at 03:49:48PM +0300, Alexander Turenko wrote:
> It still supports only clang, so use CC=clang CXX=clang++ cmake
> -DENABLE_ASAN on systems where gcc is default compiler.
> 
> Fixes #3070.
> ---
> 
> https://github.com/tarantool/tarantool/issues/3070
> https://github.com/tarantool/tarantool/tree/Totktonada/gh-3070-fix-asan
> 
>  src/fiber.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/fiber.c b/src/fiber.c
> index 7658a2294..743ceff7a 100644
> --- a/src/fiber.c
> +++ b/src/fiber.c
> @@ -54,7 +54,7 @@ static int (*fiber_invoke)(fiber_func f, va_list ap);
>  	__sanitizer_start_switch_fiber((will_switch_back) ? &var_name : NULL, \
>                                         (bottom), (size))
>  #define ASAN_FINISH_SWITCH_FIBER(var_name) \
> -	__sanitizer_finish_switch_fiber(var_name);
> +	__sanitizer_finish_switch_fiber(var_name, 0, 0);

This won't work on my laptop, which has clang-3.9. Can we support all
clang versions?