From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Tue, 18 Dec 2018 15:02:39 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH 0/4] Fix sql_bind leak
Message-ID: <20181218120239.4w6srllii5ed4ehs@esperanza>
References: <cover.1544477760.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1544477760.git.v.shpilevoy@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Tue, Dec 11, 2018 at 12:40:37AM +0300, Vladislav Shpilevoy wrote:
> The patchset makes struct sql_request consist of raw undecoded
> MessagePack and moves its decoding into TX thread as suggested by
> Kostja. Now sql_bind parameter array is decoded and freed in TX
> thread in a single function. On the contrary, before the patch,
> sql_bind parameters array was allocated on iproto thread region
> and never was freed.
> 
> As a follow up it allowed to move xrow_decode_sql and struct
> sql_request to xrow lib where all other binary requests live.
> 
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-3828-bind-parameters-leak

You forgot to push it.

> Issue: https://github.com/tarantool/tarantool/issues/3828
> 
> Vladislav Shpilevoy (4):
>   sql: remove sync from sql_request/response
>   Revert "box: store sql text and length in sql_request"
>   sql: decode bind parameters in TX thread
>   sql: move sql_request and xrow_decode_sql to xrow lib

Applied all to 2.1 (from email).