From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Tue, 18 Dec 2018 13:11:08 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH 1/1] Fix gcov on Mac
Message-ID: <20181218101108.wt5vd2sxztx7d4pc@esperanza>
References: <0b5a8c7bdf150d855e500e1dfa971bf47ec70daf.1545047861.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0b5a8c7bdf150d855e500e1dfa971bf47ec70daf.1545047861.git.v.shpilevoy@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

Alexander, please take a look.

On Mon, Dec 17, 2018 at 02:58:21PM +0300, Vladislav Shpilevoy wrote:
> ---
> https://github.com/tarantool/tarantool/tree/gerold103/enable-gcov-on-mac
> 
>  cmake/profile.cmake | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/cmake/profile.cmake b/cmake/profile.cmake
> index 278399155..866c8a787 100644
> --- a/cmake/profile.cmake
> +++ b/cmake/profile.cmake
> @@ -1,12 +1,16 @@
> -check_library_exists (gcov __gcov_flush  ""  HAVE_GCOV)
> +check_library_exists(gcov __gcov_flush  ""  HAVE_GCOV)
>  
>  set(ENABLE_GCOV_DEFAULT OFF)
>  option(ENABLE_GCOV "Enable integration with gcov, a code coverage program" ${ENABLE_GCOV_DEFAULT})
>  
>  if (ENABLE_GCOV)
>      if (NOT HAVE_GCOV)
> -    message (FATAL_ERROR
> -         "ENABLE_GCOV option requested but gcov library is not found")
> +        if (CMAKE_COMPILER_IS_CLANG)
> +            message(WARNING "GCOV is available on clang from 3.0.0")
> +            set(HAVE_GCOV 1)
> +        else()
> +            message(FATAL_ERROR "ENABLE_GCOV option requested but gcov library is not found")
> +        endif()
>      endif()
>  
>      add_compile_flags("C;CXX"
> @@ -18,8 +22,6 @@ if (ENABLE_GCOV)
>      set (CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -ftest-coverage")
>      set (CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -fprofile-arcs")
>      set (CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -ftest-coverage")
> -
> -   # add_library(gcov SHARED IMPORTED)
>  endif()
>  
>  if (NOT CMAKE_BUILD_TYPE STREQUAL "Debug")