From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C0087225BE for ; Fri, 14 Dec 2018 05:34:36 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t4XxDXbmWocD for ; Fri, 14 Dec 2018 05:34:36 -0500 (EST) Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2824722563 for ; Fri, 14 Dec 2018 05:34:36 -0500 (EST) Date: Fri, 14 Dec 2018 13:34:31 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] sql: increment VIEW counter for tables within sub-select Message-ID: <20181214103431.2cpcynm4xgsoe632@tarantool.org> References: <20181203150037.60513-1-korablev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181203150037.60513-1-korablev@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Nikita Pettik Hello, On 03 Dec 18:00, Nikita Pettik wrote: > VIEW can be created not only in form of AS SELECT but also in form of AS > VALUES (...). In the latter case space's view reference counters were > not incremented. Furthermore, if view came with sub-select, reference > counters of tables within sub-select were not updated as well. These > problems occurred due to simplified traverse over AST: only tables > within FROM clause were accounted. This patch fixes them introducing > complete pass over AST using walker. > > Closes #3815 > --- > Branch: https://github.com/tarantool/tarantool/commits/np/gh-3815-drop-view-as-values > Issue: https://github.com/tarantool/tarantool/issues/3815 I've checked your patch into 2.1 branch. -- Regards, Kirill Yukhin