From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 9 Dec 2018 00:46:26 +0300 From: Konstantin Osipov Subject: Re: [PATCH v2 09/10] wal: pass struct instead of vclock to checkpoint methods Message-ID: <20181208214626.GK2217@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/12/09 00:15]: > Currently, we only need to pass a vclock between TX and WAL during > checkpointing. However, in order to implement auto-checkpointing > triggered when WAL size exceeds a certain threshold, we will need to > pass some extra info so that we can properly reset the counter > accounting the WAL size in the WAL thread. To make it possible, let's > move wal_checkpoint struct, which is used internally by WAL to pass a > checkpoint vclock, to the header and require the caller to pass it to > wal_begin/commit_checkpoint instead of just a vclock. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov