From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 9 Dec 2018 00:45:58 +0300 From: Konstantin Osipov Subject: Re: [PATCH v2 08/10] Rewrite checkpoint daemon in C Message-ID: <20181208214558.GJ2217@chai> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/12/09 00:15]: > Long time ago, when the checkpoint daemon was added to Tarantool, it was > responsible not only for making periodic checkpoints, but also for > maintaining the configured number of checkpoints and removing old snap > and xlog files, so it was much easier to implement it in Lua than in C. > However, over time, all its responsibilities have been reimplemented in > C and moved to the server code so that now it just calls box.snapshot() > periodically. Let's rewrite this simple procedure in C as well - this > will allow us to easily add more complex logic there, e.g. triggering > checkpoint when WAL files exceed a configured threshold. > > Note, this patch removes a few cases from xlog/checkpoint_daemon test > that tested the internal state of the checkpoint daemon, which isn't > available in Lua anymore. This is OK as those cases are covered by > unit/checkpoint_schedule test. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov