From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 9 Dec 2018 00:43:45 +0300 From: Konstantin Osipov Subject: Re: [PATCH v2 04/10] box: don't use box_checkpoint_is_in_progress outside box.cc Message-ID: <20181208214345.GF2217@chai> References: <9fc9cb3fbc469e505c8253ae8591a1c924d5b54a.1544282224.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9fc9cb3fbc469e505c8253ae8591a1c924d5b54a.1544282224.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/12/09 00:15]: > We only use box_checkpoint_is_in_progress in SIGUSR1 signal handler to > print a warning in case checkpointing cannot be started, because it's > already done by another fiber. Actually, it's not necessary to use it > there - instead we can simply log the error returned by box_checkpoint, > which will be self-explaining ER_CHECKPOINT_IN_PROGRESS in this case. > So let's make box_checkpoint_is_in_progress private to box.cc - this > will simplify moving the checkpoint daemon to the gc module. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov