From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 9 Dec 2018 00:42:40 +0300 From: Konstantin Osipov Subject: Re: [PATCH v2 03/10] box: fix certain cfg options initialized twice on recovery Message-ID: <20181208214240.GE2217@chai> References: <840b3031c7164aaa95522cc591213eaac6659c82.1544282224.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <840b3031c7164aaa95522cc591213eaac6659c82.1544282224.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/12/09 00:15]: > Certain dynamic configuration options are initialized right in box.cc, > because they are needed for recovery. All such options are supposed to > be present in dynamic_cfg_skip_at_load table so that load_cfg.lua won't > try to set them again upon recovery completion. However, not all of them > happen to be there - sometime we simply forgot to patch this table after > introduction of a new configuration option. This patch adds all the > missing ones except checkpoint_count - there's no point to initialize > checkpoint_count in box.cc so it removes it from box.cc instead. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov