From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 8 Dec 2018 18:12:43 +0300 From: Alexander Turenko Subject: Re: [tarantool-patches] Re: [PATCH 0/2 v2] fio: show function name in all fio errors Message-ID: <20181208151243.nk4elwijynbrl4ao@tkn_work_nb> References: <20181204161239.3ngth5tqnt33ixk2@esperanza> <20181207072535.72jfepnrjj44vfnw@tkn_work_nb> <565504fd-61a3-092a-c9df-98b93c064a3c@tarantool.org> <20181208143609.jh6yynsar2gg62rw@tkn_work_nb> <7e53f970-d58b-2ed6-9b8d-80cdf6e63c0a@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7e53f970-d58b-2ed6-9b8d-80cdf6e63c0a@tarantool.org> To: roman Cc: tarantool-patches@freelists.org, Vladislav Shpilevoy , Vladimir Davydov List-ID: On Sat, Dec 08, 2018 at 06:02:43PM +0300, roman wrote: > > Now the code looks good to me. > > > > But commit messages (of both commits) now do not reflect code changes. > > Please, squash commits and fix the commit message. > > > > WBR, Alexander Turenko. > Done. Now ok. Please, proceed further with Vova. I see the patch is based on 1.10. Maybe maintainers will ask you to base it on top of 2.1. WBR, Alexander Turenko.