From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Date: Sat, 8 Dec 2018 17:36:09 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [tarantool-patches] Re: [PATCH 0/2 v2] fio: show function name
 in all fio errors
Message-ID: <20181208143609.jh6yynsar2gg62rw@tkn_work_nb>
References: <cover.1543938959.git.roman.habibov@tarantool.org>
 <20181204161239.3ngth5tqnt33ixk2@esperanza>
 <20181207072535.72jfepnrjj44vfnw@tkn_work_nb>
 <565504fd-61a3-092a-c9df-98b93c064a3c@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <565504fd-61a3-092a-c9df-98b93c064a3c@tarantool.org>
To: roman <roman.habibov@tarantool.org>
Cc: tarantool-patches@freelists.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, Vladimir Davydov <vdavydov.dev@gmail.com>
List-ID: <tarantool-patches.dev.tarantool.org>

On Sat, Dec 08, 2018 at 04:41:08PM +0300, roman wrote:
> 
> Hi! Thanks for review.
> > I think within scope of this issue we should only add function names
> > into error messages and add path part number, but remove the second
> > parameter of the error() function where it is used across the fio
> > module.
> 
> Removed.

Now the code looks good to me.

But commit messages (of both commits) now do not reflect code changes.
Please, squash commits and fix the commit message.

WBR, Alexander Turenko.