From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja@tarantool.org>
Date: Fri, 7 Dec 2018 20:38:56 +0300
From: Konstantin Osipov <kostja@tarantool.org>
Subject: Re: [tarantool-patches] [PATCH 3/4] session: introduce 'dead' type
Message-ID: <20181207173856.GE840@chai>
References: <cover.1544197465.git.v.shpilevoy@tarantool.org>
 <e156739b41cec81767509fa781200a4d24baf03b.1544197465.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e156739b41cec81767509fa781200a4d24baf03b.1544197465.git.v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org
Cc: vdavydov.dev@gmail.com
List-ID: <tarantool-patches.dev.tarantool.org>

* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [18/12/07 18:48]:
> If an iproto connection is closed, there are no way
> how to determine if this happened. Except setting an
> on_disconnect trigger which sets a global flag or
> something.
> 
> To deal with such orphan requests a new session type
> is introduced that can be checked inside a request.

Please don't reset session type when it becomes dead.
What's the problem with storing an explicit vtab pointer in the
session and resetting it? 
> 
> Needed for #3859
> ---
>  src/box/session.cc |  2 ++
>  src/box/session.h  | 14 ++++++++++++++
>  2 files changed, 16 insertions(+)
> 

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov