From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 7 Dec 2018 20:36:01 +0300 From: Konstantin Osipov Subject: Re: [tarantool-patches] [PATCH 1/4] iproto: rename disconnect cmsg to destroy Message-ID: <20181207173601.GC840@chai> References: <2168d008e70590a87851bbf602a811d22441b586.1544197465.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2168d008e70590a87851bbf602a811d22441b586.1544197465.git.v.shpilevoy@tarantool.org> To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com List-ID: * Vladislav Shpilevoy [18/12/07 18:48]: > Disconnect cmsg is a message that is used by iproto > thread to notify tx thread that a connection is dead > and has no outstanding requests. That is its > tx-related resourses are freed and the connection is > deleted. > > But the text above is clear definition of destroy. The > patch harmonizes cmsg name and its puprose. > > Secondly, the patch is motivated by #3859 which > requires separate disconnect and destroy phases. > OK to push. > Needed for #3859 -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov