From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 9C7F32D4E6 for ; Thu, 6 Dec 2018 09:56:28 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Kc0D4pCkOh-N for ; Thu, 6 Dec 2018 09:56:28 -0500 (EST) Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A5F972D4C7 for ; Thu, 6 Dec 2018 09:56:25 -0500 (EST) Date: Thu, 6 Dec 2018 17:56:19 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v2 1/1] sql: fix parser.parse_only mode for triggers Message-ID: <20181206145619.fuf7wnfdredvlxy3@tarantool.org> References: <0943b4db119f16a30aad8198943568521508dfdb.1543507402.git.kshcherbatov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0943b4db119f16a30aad8198943568521508dfdb.1543507402.git.kshcherbatov@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Kirill Shcherbatov Hello, On 29 Nov 19:03, Kirill Shcherbatov wrote: > The sql_trigger_compile routine had a Vdbe leak as parser doesn't > releases VM(it is not required in typical scenario). As the > parse_only flag had not worked correctly for sql triggers > sql_trigger_compile have had a memory leak. > > Closes #3838 I've checked your patch into 2.1 branch. -- Regards, Kirill Yukhin