From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 6 Dec 2018 11:06:26 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] Re: [PATCH v5 3/9] box: manage format fields with JSON tree class Message-ID: <20181206080626.x6dnpj4d7ddkycow@esperanza> References: <0ff5601b664e42d70d71be658b4ba45fe1237564.1543229303.git.kshcherbatov@tarantool.org> <20181129190757.oyu7kom6drgacd3j@esperanza> <5133fc03-e2ed-0bea-d3d1-47b4b60121e9@tarantool.org> <20181204160922.m5bse7haiiunyvpf@esperanza> <08d1a08e-e2b5-dd36-82b5-8c3a14bb0d7f@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <08d1a08e-e2b5-dd36-82b5-8c3a14bb0d7f@tarantool.org> To: Kirill Shcherbatov Cc: tarantool-patches@freelists.org, Kostya Osipov List-ID: On Thu, Dec 06, 2018 at 10:56:55AM +0300, Kirill Shcherbatov wrote: > As we going to work with format fields in a unified way, we > started to use the tree JSON class for working with first-level > format fields. > > Needed for #1012 > --- > src/box/sql.c | 18 +++--- > src/box/sql/build.c | 5 +- > src/box/tuple.c | 10 ++-- > src/box/tuple_format.c | 122 +++++++++++++++++++++++++++++------------ > src/box/tuple_format.h | 49 ++++++++++++++--- > src/box/vy_stmt.c | 4 +- > 6 files changed, 148 insertions(+), 60 deletions(-) I don't understand what have changed and why you have to resend this patch. Please push the patches you think are ready to a separate branch and resend them as a separate thread. And please write a change log describing briefly what have changed since the last version.